This is an archive of the discontinued LLVM Phabricator instance.

Terminate early for DS_Error
AbandonedPublic

Authored by kongyi on May 26 2020, 2:17 AM.

Summary

Otherwise clang will continue running after printing the diagnostic, causing failures later in other modes, or maybe even finish successfully.

	Time	Test
	30 ms	Clang.CodeGenCXX::Unknown Unit Message ("")
	90 ms	Clang.CodeGenCXX::Unknown Unit Message ("")

Path

Size

clang/

lib/

CodeGen/

3 lines

Show First 20 Lines • Show All 893 Lines • ▼ Show 20 Lines	if (DiagID == diag::err_fe_cannot_link_module) {
Diags.Report(diag::err_fe_cannot_link_module)		Diags.Report(diag::err_fe_cannot_link_module)
<< CurLinkModule->getModuleIdentifier() << MsgStorage;		<< CurLinkModule->getModuleIdentifier() << MsgStorage;
return;		return;
}		}

// Report the backend message using the usual diagnostic mechanism.		// Report the backend message using the usual diagnostic mechanism.
FullSourceLoc Loc;		FullSourceLoc Loc;
Diags.Report(Loc, DiagID).AddString(MsgStorage);		Diags.Report(Loc, DiagID).AddString(MsgStorage);

		if (Severity == DS_Error)
		exit(1);
}		}
#undef ComputeDiagID		#undef ComputeDiagID

CodeGenAction::CodeGenAction(unsigned _Act, LLVMContext *_VMContext)		CodeGenAction::CodeGenAction(unsigned _Act, LLVMContext *_VMContext)
: Act(_Act), VMContext(_VMContext ? _VMContext : new LLVMContext),		: Act(_Act), VMContext(_VMContext ? _VMContext : new LLVMContext),
OwnsVMContext(!_VMContext) {}		OwnsVMContext(!_VMContext) {}

CodeGenAction::~CodeGenAction() {		CodeGenAction::~CodeGenAction() {
▲ Show 20 Lines • Show All 302 Lines • Show Last 20 Lines