Page MenuHomePhabricator

Turn -Wmax-tokens off by default

Authored by hans on Fri, May 15, 8:25 AM.



On the one hand, one might interpret the use of the max-token pragmas or -fmax-tokens flag as an opt-in to the warning. However, in Chromium we've found it useful to only opt in selected build configurations, even though we have the pragmas in the code. For that reason, we think it makes sense to turn it off by default.

Diff Detail

Event Timeline

hans created this revision.Fri, May 15, 8:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, May 15, 8:25 AM
thakis accepted this revision.Fri, May 15, 8:43 AM
This revision is now accepted and ready to land.Fri, May 15, 8:43 AM
This revision was automatically updated to reflect the committed changes.