This is an archive of the discontinued LLVM Phabricator instance.

Differential D79813

[Statepoint] Mark FixupStatepointCallerSaved as preserving the CFG
ClosedPublic

Authored by craig.topper on May 12 2020, 3:19 PM.

Details

Reviewers
skatkov
nikic
Commits
rGde92dc2850c1: [Statepoint] Mark FixupStatepointCallerSaved as preserving the CFG
Summary

I can't find anything obvious in this pass that invalidates the CFG. So mark it as preserving so we stop rerunning some analysis passes.

I'm hoping this will restore some compile time lost by D75936 and D75937.

Diff Detail

Event Timeline

craig.topper created this revision.May 12 2020, 3:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2020, 3:19 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
skatkov accepted this revision.May 12 2020, 7:29 PM

You are right, CFG is not modified. Thank you for the change.

This revision is now accepted and ready to land.May 12 2020, 7:29 PM
Closed by commit rGde92dc2850c1: [Statepoint] Mark FixupStatepointCallerSaved as preserving the CFG (authored by craig.topper). · Explain WhyMay 13 2020, 11:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
1 line
test/
CodeGen/
ARM/
3 lines
X86/
2 lines

Diff 263797

llvm/lib/CodeGen/FixupStatepointCallerSaved.cpp

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
public: public:
static char ID; static char ID;
FixupStatepointCallerSaved() : MachineFunctionPass(ID) { FixupStatepointCallerSaved() : MachineFunctionPass(ID) {
initializeFixupStatepointCallerSavedPass(*PassRegistry::getPassRegistry()); initializeFixupStatepointCallerSavedPass(*PassRegistry::getPassRegistry());
} }
void getAnalysisUsage(AnalysisUsage &AU) const override { void getAnalysisUsage(AnalysisUsage &AU) const override {
AU.setPreservesCFG();
MachineFunctionPass::getAnalysisUsage(AU); MachineFunctionPass::getAnalysisUsage(AU);
} }
StringRef getPassName() const override { StringRef getPassName() const override {
return "Fixup Statepoint Caller Saved"; return "Fixup Statepoint Caller Saved";
} }
bool runOnMachineFunction(MachineFunction &MF) override; bool runOnMachineFunction(MachineFunction &MF) override;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

llvm/test/CodeGen/ARM/O3-pipeline.ll

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Lines
; CHECK-NEXT: Machine Optimization Remark Emitter ; CHECK-NEXT: Machine Optimization Remark Emitter
; CHECK-NEXT: Greedy Register Allocator ; CHECK-NEXT: Greedy Register Allocator
; CHECK-NEXT: Virtual Register Rewriter ; CHECK-NEXT: Virtual Register Rewriter
; CHECK-NEXT: Stack Slot Coloring ; CHECK-NEXT: Stack Slot Coloring
; CHECK-NEXT: Machine Copy Propagation Pass ; CHECK-NEXT: Machine Copy Propagation Pass
; CHECK-NEXT: Machine Loop Invariant Code Motion ; CHECK-NEXT: Machine Loop Invariant Code Motion
; CHECK-NEXT: Fixup Statepoint Caller Saved ; CHECK-NEXT: Fixup Statepoint Caller Saved
; CHECK-NEXT: PostRA Machine Sink ; CHECK-NEXT: PostRA Machine Sink
; CHECK-NEXT: MachineDominator Tree Construction
; CHECK-NEXT: Machine Natural Loop Construction
; CHECK-NEXT: Machine Block Frequency Analysis ; CHECK-NEXT: Machine Block Frequency Analysis
; CHECK-NEXT: MachineDominator Tree Construction
; CHECK-NEXT: MachinePostDominator Tree Construction ; CHECK-NEXT: MachinePostDominator Tree Construction
; CHECK-NEXT: Lazy Machine Block Frequency Analysis ; CHECK-NEXT: Lazy Machine Block Frequency Analysis
; CHECK-NEXT: Machine Optimization Remark Emitter ; CHECK-NEXT: Machine Optimization Remark Emitter
; CHECK-NEXT: Shrink Wrapping analysis ; CHECK-NEXT: Shrink Wrapping analysis
; CHECK-NEXT: Prologue/Epilogue Insertion & Frame Finalization ; CHECK-NEXT: Prologue/Epilogue Insertion & Frame Finalization
; CHECK-NEXT: Control Flow Optimizer ; CHECK-NEXT: Control Flow Optimizer
; CHECK-NEXT: Lazy Machine Block Frequency Analysis ; CHECK-NEXT: Lazy Machine Block Frequency Analysis
; CHECK-NEXT: Tail Duplication ; CHECK-NEXT: Tail Duplication
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines

llvm/test/CodeGen/X86/O3-pipeline.ll

Show First 20 Lines • Show All 140 Lines • ▼ Show 20 Lines
; CHECK-NEXT: Machine Loop Invariant Code Motion ; CHECK-NEXT: Machine Loop Invariant Code Motion
; CHECK-NEXT: Bundle Machine CFG Edges ; CHECK-NEXT: Bundle Machine CFG Edges
; CHECK-NEXT: X86 FP Stackifier ; CHECK-NEXT: X86 FP Stackifier
; CHECK-NEXT: MachineDominator Tree Construction ; CHECK-NEXT: MachineDominator Tree Construction
; CHECK-NEXT: Machine Dominance Frontier Construction ; CHECK-NEXT: Machine Dominance Frontier Construction
; CHECK-NEXT: X86 Load Value Injection (LVI) Load Hardening ; CHECK-NEXT: X86 Load Value Injection (LVI) Load Hardening
; CHECK-NEXT: Fixup Statepoint Caller Saved ; CHECK-NEXT: Fixup Statepoint Caller Saved
; CHECK-NEXT: PostRA Machine Sink ; CHECK-NEXT: PostRA Machine Sink
; CHECK-NEXT: MachineDominator Tree Construction
; CHECK-NEXT: Machine Natural Loop Construction
; CHECK-NEXT: Machine Block Frequency Analysis ; CHECK-NEXT: Machine Block Frequency Analysis
; CHECK-NEXT: MachinePostDominator Tree Construction ; CHECK-NEXT: MachinePostDominator Tree Construction
; CHECK-NEXT: Lazy Machine Block Frequency Analysis ; CHECK-NEXT: Lazy Machine Block Frequency Analysis
; CHECK-NEXT: Machine Optimization Remark Emitter ; CHECK-NEXT: Machine Optimization Remark Emitter
; CHECK-NEXT: Shrink Wrapping analysis ; CHECK-NEXT: Shrink Wrapping analysis
; CHECK-NEXT: Prologue/Epilogue Insertion & Frame Finalization ; CHECK-NEXT: Prologue/Epilogue Insertion & Frame Finalization
; CHECK-NEXT: Control Flow Optimizer ; CHECK-NEXT: Control Flow Optimizer
; CHECK-NEXT: Lazy Machine Block Frequency Analysis ; CHECK-NEXT: Lazy Machine Block Frequency Analysis
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines