This is an archive of the discontinued LLVM Phabricator instance.

Make print_cwd buildable on Windows
ClosedPublic

Authored by amccarth on Feb 27 2015, 2:28 PM.

Reviewers

Commits

Summary

Original code relied on POSIX feature. This change doesn't completely enable process_launch tests on Windows, but it's another step in the chain.

amccarth retitled this revision from to Make print_cwd buildable on Windows.

amccarth updated this object.

amccarth edited the test plan for this revision. (Show Details)

amccarth added a reviewer: zturner.

amccarth added a subscriber: Unknown Object (MLST).

zturner edited edge metadata.

zturner added inline comments.

test/functionalities/process_launch/print_cwd.cpp
3	I think this should be _MSC_VER. mingw toolchains will still have <unistd.h> and getcwd. We compile all our tests with clang, which does define _MSC_VER when in MSABI compat mode. lgtm otherwise, I'll commit later.

This revision is now accepted and ready to land.Feb 27 2015, 2:42 PM

Makes sense. Changed to _MSC_VER. Thanks.

No worries, I would have changed it for you before submitting anyway :)
Thanks!

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

functionalities/

process_launch/

8 lines

	#include <stdio.h>			#include <stdio.h>

				#ifdef _WIN32
				zturnerUnsubmitted Not Done Reply Inline Actions I think this should be _MSC_VER. mingw toolchains will still have <unistd.h> and getcwd. We compile all our tests with clang, which does define _MSC_VER when in MSABI compat mode. lgtm otherwise, I'll commit later. zturner: I think this should be _MSC_VER. mingw toolchains will still have <unistd.h> and getcwd. We…
				#define _CRT_NONSTDC_NO_WARNINGS
				#include <direct.h>
				#undef getcwd
				#define getcwd(buffer, length) _getcwd(buffer, length)
				#else
	#include <unistd.h>			#include <unistd.h>
				#endif

	int			int
	main (int argc, char **argv)			main (int argc, char **argv)
	{			{
	char buffer[1024];			char buffer[1024];

	fprintf(stdout, "stdout: %s\n", getcwd(buffer, 1024));			fprintf(stdout, "stdout: %s\n", getcwd(buffer, 1024));
	fprintf(stderr, "stderr: %s\n", getcwd(buffer, 1024));			fprintf(stderr, "stderr: %s\n", getcwd(buffer, 1024));

	return 0;			return 0;
	}			}