Added ability to XToolchainBuilder have extra steps to run checks on a remote target.

[aorlov]

Summary

Checks on target steps are configurable as an array of tuples - the step name and the command to run on that step.

[gkistanova]

LGTM with a nit pick.

zorg/buildbot/builders/XToolchainBuilder.py

22

It seems the name in the tuple is not a step name, but rather a check name?
The step name is formed dynamically in the line 202.

zorg/buildbot/builders/XToolchainBuilder.py

def getCmakeWithMSVCBuildFactory(
         clean = True,                # False for incremental builds.
         depends_on_projects  = None, # List of projects to listen.
         cmake_cache = None,          # Path to a cmake cache file.
         extra_configure_args = None, # Extra CMake args if any.
         llvm_srcdir = None,          # Source code root directory.
         obj_dir = None,              # Build tree root directory.
         install_dir = None,          # Directory to install the results to.
         checks = None,               # List of checks to test the build.
+        checks_on_target = None,     # [(<name>,[<command tokens>])] array of
+                                     # check name and command to run on target.
         jobs = None,                 # Restrict a degree of parallelism.
         env  = None,                 # Environmental variables for all steps.
         # VS tools environment variable if using MSVC.
         # For example, "autodetect" to auto detect, %VS140COMNTOOLS% to select
         # the VS 2015 toolchain, or empty string if environment is already set.
         vs=None,
         **kwargs):
 
for check in checks:
                     "Testing", "just", "built", "components", "for", check],
                 descriptionDone=[
                     "Test", "just", "built", "components", "for", check,
                      "completed"],
                 env=merged_env,
                 **kwargs # Pass through all the extra arguments.
                 ))
 
+    # Run commands on a target if requested.
+    if checks_on_target:
+        for check, cmd in checks_on_target:
+            f.addStep(
+                LitTestCommand(
+                    haltOnFailure=False, # We want to test as much as we could.
+                    name='test-%s' % check,
+                    command=cmd,
+                    description=[
+                        "Testing", "just", "built", "components", "for", check],
+                    descriptionDone=[
+                        "Test", "just", "built", "components", "for", check,
+                        "completed"],
+                    env=merged_env,
+                    **kwargs # Pass through all the extra arguments.
+                    ))
+
     # Install just built components
     if install_dir:
         f.addStep(NinjaCommand(name="install-all",
                                haltOnFailure=True,
                                targets=["install"],
                                description=[
                                    "Install", "just", "built", "components"],
                                workdir=f.obj_dir,
                                env=merged_env,
                                **kwargs # Pass through all the extra arguments.
                                ))
 
     return f