This is an archive of the discontinued LLVM Phabricator instance.

Differential D78109

Ran git clang-format
AbandonedPublic

Authored by kwk on Apr 14 2020, 6:55 AM.

Details

Reviewers
None
Summary

Depends on D74136.

Diff Detail

Event Timeline

kwk created this revision.Apr 14 2020, 6:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2020, 6:55 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
kwk abandoned this revision.Apr 14 2020, 6:57 AM

Sorry, wrong arc diff invocation.

Harbormaster failed remote builds in B53127: Diff 257312!Apr 14 2020, 7:27 AM

Revision Contents

PathSize
lldb/
source/
Core/
4 lines

Diff 257312

lldb/source/Core/SearchFilter.cpp

//===-- SearchFilter.cpp --------------------------------------------------===// //===-- SearchFilter.cpp --------------------------------------------------===//
Lint: Lint
Inline Actions

clang-format-diff not found in user's PATH; not linting file.

Lint: Lint: clang-format-diff not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 703 Lines • ▼ Show 20 Lines if (!sym_ctx.comp_unit) {
if (m_cu_spec_list.GetSize() != 0) if (m_cu_spec_list.GetSize() != 0)
return false; // Has no comp_unit so can't pass the file check. return false; // Has no comp_unit so can't pass the file check.
} }
FileSpec cu_spec; FileSpec cu_spec;
if (sym_ctx.comp_unit) if (sym_ctx.comp_unit)
cu_spec = sym_ctx.comp_unit->GetPrimaryFile(); cu_spec = sym_ctx.comp_unit->GetPrimaryFile();
if (m_cu_spec_list.FindFileIndex(0, cu_spec, false) != UINT32_MAX) if (m_cu_spec_list.FindFileIndex(0, cu_spec, false) != UINT32_MAX)
return true; return true;
// ^ If the primary source file associated with the symbol's compile unit is in // ^ If the primary source file associated with the symbol's compile unit is
// the list of CU's or support files, that's enough. // in the list of CU's or support files, that's enough.
// TODO(kwk): Is that enough? // TODO(kwk): Is that enough?
return SearchFilterByModuleList::ModulePasses(sym_ctx.module_sp); return SearchFilterByModuleList::ModulePasses(sym_ctx.module_sp);
} }
bool SearchFilterByModuleListAndCU::CompUnitPasses(FileSpec &fileSpec) { bool SearchFilterByModuleListAndCU::CompUnitPasses(FileSpec &fileSpec) {
return m_cu_spec_list.FindFileIndex(0, fileSpec, false) != UINT32_MAX; return m_cu_spec_list.FindFileIndex(0, fileSpec, false) != UINT32_MAX;
} }
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines