Set error status when failed to catch stop after launch

[tberghammer]

Summary

Set error status when failed to catch stop after launch

Process::Launch try to catch a stop signal after launching a process. If it is unsuccessful it destroy the process but previously still reported that the process launched successfully. This behavior caused a deadlock. With this change the process launch error reported correctly.

[clayborg]

Looks good.

[ovyalov]

lgtm

source/Target/Process.cpp

if (exe_module)
                     timeout_time = TimeValue::Now();
                     timeout_time.OffsetWithSeconds(10);
                     StateType state = WaitForProcessStopPrivate(&timeout_time, event_sp);
 
                     if (state == eStateInvalid || event_sp.get() == NULL)
                     {
                         // We were able to launch the process, but we failed to
                         // catch the initial stop.
+                        error.SetErrorString ("failed to catch stop after launch");
                         SetExitStatus (0, "failed to catch stop after launch");
                         Destroy();
                     }
                     else if (state == eStateStopped || state == eStateCrashed)
                     {
 
                         DidLaunch ();