Page MenuHomePhabricator

[obj2yaml] - Do not dump the segment's "Align" field when it is equal to 1.
ClosedPublic

Authored by grimar on Apr 8 2020, 3:22 AM.

Details

Summary

yaml2obj sets the Align to 1 by default, hence we can stop
dumping it to reduce the output.

Diff Detail

Event Timeline

grimar created this revision.Apr 8 2020, 3:22 AM
MaskRay accepted this revision.Apr 8 2020, 12:59 PM

Looks great!

llvm/tools/obj2yaml/elf2yaml.cpp
322

Omit it to reduce output?

This revision is now accepted and ready to land.Apr 8 2020, 12:59 PM
grimar marked an inline comment as done.Apr 9 2020, 3:57 AM
grimar added inline comments.
llvm/tools/obj2yaml/elf2yaml.cpp
322

I'd keep the current version: as we already have the another comment in this file saying almost the same: "Generally we are trying to reduce noise in the YAML output.". (I am not sure that "reducing the output" is better describes our goal, we want to omit unnessesary parts, it is very close and reduces the output, but is not 100% the same probably.)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 9 2020, 4:50 AM