Page MenuHomePhabricator

clang-format: [js] Support ES6 module imports.
ClosedPublic

Authored by mprobst on Feb 19 2015, 5:07 AM.

Details

Reviewers
djasper

Diff Detail

Event Timeline

mprobst updated this revision to Diff 20284.Feb 19 2015, 5:07 AM
mprobst retitled this revision from to clang-format: [js] Support ES6 module imports..
mprobst updated this object.
mprobst edited the test plan for this revision. (Show Details)
mprobst added a reviewer: djasper.
mprobst added subscribers: Unknown Object (MLST), Unknown Object (MLST).
mprobst updated this revision to Diff 20285.Feb 19 2015, 5:08 AM
mprobst added inline comments.
lib/Format/TokenAnnotator.cpp
1920

NB: This is a refactoring that I missed adding to the last patch.

djasper added inline comments.Feb 19 2015, 7:46 AM
lib/Format/UnwrappedLineParser.cpp
1607

Maybe:

assert(FormatTok->is(Keywords.kw_import));

instead of the comment?

unittests/Format/FormatTestJS.cpp
529

The first part seems obsolete and I am not sure what you mean by the second.

mprobst updated this revision to Diff 20301.Feb 19 2015, 7:52 AM
mprobst added inline comments.
lib/Format/UnwrappedLineParser.cpp
1607

Done.

unittests/Format/FormatTestJS.cpp
529

Dropped, obsolete indeed.

djasper accepted this revision.Feb 19 2015, 8:09 AM
djasper edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2015, 8:09 AM

Submitted as r229863.

djasper closed this revision.Feb 19 2015, 8:09 AM

Submitted as r229863.