This is an archive of the discontinued LLVM Phabricator instance.

[ASan] set DYLD_LIBRARY_PATH on Darwin
ClosedPublic

Authored by garious on Feb 17 2015, 3:20 PM.

Download Raw Diff

Details

Reviewers

Commits

rG127f4e5c6a9e: [ASan] Set DYLD_LIBRARY_PATH on Darwin
rCRT229714: [ASan] Set DYLD_LIBRARY_PATH on Darwin
rL229714: [ASan] Set DYLD_LIBRARY_PATH on Darwin

Summary

The CMake build doesn't seem to be as well supported on Darwin as it is Linux. This patch takes the test suite from ~50 tests passing to 266 passing (34 failing).

Diff Detail

Repository: rL LLVM

Event Timeline

garious updated this revision to Diff 20114.Feb 17 2015, 3:20 PM

garious retitled this revision from to [ASan] set DYLD_LIBRARY_PATH on Darwin.

garious updated this object.

garious edited the test plan for this revision. (Show Details)

garious added a reviewer: samsonov.

garious set the repository for this revision to rL LLVM.

garious added a subscriber: Unknown Object (MLST).

LGTM

test/asan/lit.cfg
18	Do you need to make the same fix to test/asan/Unit/lit.site.cfg.in?

This revision is now accepted and ready to land.Feb 17 2015, 4:35 PM

Closed by commit rL229714: [ASan] Set DYLD_LIBRARY_PATH on Darwin (authored by garious). · Explain WhyFeb 18 2015, 10:29 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test/

asan/

lit.cfg

2 lines

Diff 20114

test/asan/lit.cfg

Context not available.
	def push_dynamic_library_lookup_path(config, new_path):	def push_dynamic_library_lookup_path(config, new_path):
	if platform.system() == 'Windows':	if platform.system() == 'Windows':
	dynamic_library_lookup_var = 'PATH'	dynamic_library_lookup_var = 'PATH'
		elif platform.system() == 'Darwin':
		samsonovUnsubmitted Not Done Reply Inline Actions Do you need to make the same fix to test/asan/Unit/lit.site.cfg.in? samsonov: Do you need to make the same fix to test/asan/Unit/lit.site.cfg.in?
		dynamic_library_lookup_var = 'DYLD_LIBRARY_PATH'
	else:	else:
	dynamic_library_lookup_var = 'LD_LIBRARY_PATH'	dynamic_library_lookup_var = 'LD_LIBRARY_PATH'

Context not available.