Page MenuHomePhabricator

[profile] Avoid duplicating or leaking VMO
ClosedPublic

Authored by phosek on Mar 27 2020, 5:51 PM.

Details

Summary

Now that write data continuously into the memory mapping, we don't need
to keep the VMO handle around after it has been mapped. This change also
ensures that the VMO is always closed on error.

Diff Detail

Event Timeline

phosek created this revision.Mar 27 2020, 5:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2020, 5:51 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mcgrathr accepted this revision.Mar 30 2020, 1:39 PM

lgtm

compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c
181

s/closes/consumes/ (the API just says it takes ownership, you don't know whether it remains a valid handle or not)

This revision is now accepted and ready to land.Mar 30 2020, 1:39 PM
This revision was automatically updated to reflect the committed changes.