This is an archive of the discontinued LLVM Phabricator instance.

[lldb][NFC] Mention how to disable version check in reproducer in version check error message
Needs ReviewPublic

Authored by teemperor on Mar 26 2020, 8:45 AM.

Details

Reviewers
JDevlieghere
Summary

I have to keep looking at the help page to find out how this option is named.
Directly mentioning this in the error message would make my life easier.

Diff Detail

Event Timeline

teemperor created this revision.Mar 26 2020, 8:45 AM
teemperor retitled this revision from [lldb][NFC] Mention how to disable version check in reproducer to [lldb][NFC] Mention how to disable version check in reproducer in version check error message.
JDevlieghere added inline comments.Mar 26 2020, 9:25 AM
lldb/source/API/SBReproducer.cpp
157

Let's make it clear that this is an unsupported scenario:

Replaying a reproducer captured with a different version is not supported and likely to fail. Pass --reproducer-skip-version-check to disable the version check at your own risk.

kwk added a subscriber: kwk.Apr 17 2020, 2:46 AM
kwk added inline comments.
lldb/source/API/SBReproducer.cpp
157

Agreed. And do we maybe need a \n infront of the Pass?