This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Always log if acquiring packet sequence mutex fails
ClosedPublic

Authored by teemperor on Mar 24 2020, 6:01 AM.

Details

Reviewers
labath
Group Reviewers
Restricted Project
Commits
rG0ccc4de42eae: [lldb] Always log if acquiring packet sequence mutex fails
Summary

Currently we only log in debug builds but I don't see why we would do this as this is neither
expensive and seems useful.

I looked into the git history of this code and it seems originally there was also an assert here
and the logging here was the #else branch branch for non-Debug builds.

Diff Detail

Event Timeline

teemperor created this revision.Mar 24 2020, 6:01 AM
labath accepted this revision.Mar 24 2020, 6:29 AM
This revision is now accepted and ready to land.Mar 24 2020, 6:29 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2020, 12:55 PM