This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Don't dump the frame in SBTarget::EvaluateExpression in LLDB_CONFIGURATION_DEBUG
ClosedPublic

Authored by teemperor on Mar 24 2020, 4:34 AM.

Details

Summary

Dumping the frame using the user-set format could cause that a debug LLDB doesn't behave as a release LLDB,
which could potentially break replaying a reproducer.

Also it's kinda strange that the frame format set by the user is used in the internal log output.

Diff Detail

Event Timeline

teemperor created this revision.Mar 24 2020, 4:34 AM
JDevlieghere accepted this revision.Mar 24 2020, 9:05 AM
This revision is now accepted and ready to land.Mar 24 2020, 9:05 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2020, 12:23 PM