This is an archive of the discontinued LLVM Phabricator instance.

[llgo] Build cgo and llgo-go
ClosedPublic

Authored by pcc on Feb 13 2015, 3:08 PM.

Diff Detail

Event Timeline

pcc updated this revision to Diff 19938.Feb 13 2015, 3:08 PM
pcc retitled this revision from to [llgo] Build cgo and llgo-go.
pcc updated this object.
pcc edited the test plan for this revision. (Show Details)
pcc added a reviewer: axw.
pcc added a subscriber: Unknown Object (MLST).
axw accepted this revision.Feb 13 2015, 5:21 PM
axw edited edge metadata.

LGTM with .go file removed, unless I'm mistaken.

cmd/cgo/zdefaultcc.go
1

Did you mean to add this file? It doesn't match the .in file, and should just be generated during build?

This revision is now accepted and ready to land.Feb 13 2015, 5:21 PM
pcc added inline comments.Feb 13 2015, 5:25 PM
cmd/cgo/zdefaultcc.go
1

The go and cgo commands need different zdefaultcc.go files because they have different sets of variables that need to be set and are installed n different locations.

axw added a comment.Feb 13 2015, 5:31 PM

The go and cgo commands need different zdefaultcc.go files because they have different sets of variables that need to be set and are installed n different locations.

Ah, thanks, I missed the difference in path prefixes.

This revision was automatically updated to reflect the committed changes.