This is an archive of the discontinued LLVM Phabricator instance.

Minor tweak to MDA
ClosedPublic

Authored by reames on Feb 13 2015, 2:14 PM.

Details

Summary

Two minor tweaks I noticed when reading through the code:

  • No need to recompute begin() on every iteration. We're not modifying the instructions in this loop.
  • We can ignore PHINodes and Dbg intrinsics. The current code does this anyways, but it will spend slightly more time doing so and will count towards the limit of instructions in the block. It seems really silly to give up due the presence of PHIs...

Diff Detail

Event Timeline

reames updated this revision to Diff 19932.Feb 13 2015, 2:14 PM
reames retitled this revision from to Minor tweak to MDA.
reames updated this object.
reames edited the test plan for this revision. (Show Details)
reames added reviewers: hfinkel, nicholas, jfb.
reames added a subscriber: Unknown Object (MLST).
jfb accepted this revision.Feb 13 2015, 2:27 PM
jfb edited edge metadata.

lgtm otherwise.

lib/Analysis/MemoryDependenceAnalysis.cpp
426

Missing period.

This revision is now accepted and ready to land.Feb 13 2015, 2:27 PM
This revision was automatically updated to reflect the committed changes.