Correct confusion between overwrite and override

[alexfh]

Looks good. Thanks!

Do you need me to commit this for you or you have commit access?

[LegalizeAdulthood]

I tried doing a dcommit on the other review you shipped, but I get errors. I do not believe I have write access to the repository; I have an account here, but I don't think that's enough to give me write access to the repo. A previous tiny patch I submitted was committed by someone else on my behalf.

[alexfh]

Committed in r230490.

Sorry for the delay. Your reply has somehow skipped my inbox.

[alexfh]

In D7604#123711, @LegalizeAdulthood wrote:

I tried doing a dcommit on the other review you shipped, but I get errors. I do not believe I have write access to the repository; I have an account here, but I don't think that's enough to give me write access to the repo. A previous tiny patch I submitted was committed by someone else on my behalf.

An account here has nothing to do with the commit access to the repository. Once you have enough patches submitted on your behalf, you can apply for the commit access as described here: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

clang-tidy/ClangTidy.h

 
 private:
   std::string NamePrefix;
   const ClangTidyOptions::OptionMap &CheckOptions;
 };
 
 /// \brief Base class for all clang-tidy checks.
 ///
-/// To implement a \c ClangTidyCheck, write a subclass and overwrite some of the
+/// To implement a \c ClangTidyCheck, write a subclass and override some of the
 /// base class's methods. E.g. to implement a check that validates namespace
-/// declarations, overwrite \c registerMatchers:
+/// declarations, override \c registerMatchers:
 ///
 /// \code
 /// registerMatchers(ast_matchers::MatchFinder *Finder) {
 ///   Finder->addMatcher(namespaceDecl().bind("namespace"), this);
 /// }
 /// \endcode
 ///
-/// and then overwrite \c check(const MatchResult &Result) to do the actual
+/// and then override \c check(const MatchResult &Result) to do the actual
 /// check for each match.
 ///
 /// A new \c ClangTidyCheck instance is created per translation unit.
 ///
 /// FIXME: Figure out whether carrying information from one TU to another is
 /// useful/necessary.
 class ClangTidyCheck : public ast_matchers::MatchFinder::MatchCallback {
 public:
   /// \brief Initializes the check with \p CheckName and \p Context.
   ///
   /// Derived classes must implement the constructor with this signature or
   /// delegate it. If a check needs to read options, it can do this in the
   /// constructor using the Options.get() methods below.
   ClangTidyCheck(StringRef CheckName, ClangTidyContext *Context)
       : CheckName(CheckName), Context(Context),
         Options(CheckName, Context->getOptions().CheckOptions) {
     assert(Context != nullptr);
     assert(!CheckName.empty());
   }
 
   virtual ~ClangTidyCheck() {}
 
-  /// \brief Overwrite this to register \c PPCallbacks with \c Compiler.
+  /// \brief Override this to register \c PPCallbacks with \c Compiler.
   ///
   /// This should be used for clang-tidy checks that analyze preprocessor-
   /// dependent properties, e.g. the order of include directives.
   virtual void registerPPCallbacks(CompilerInstance &Compiler) {}
 
-  /// \brief Overwrite this to register ASTMatchers with \p Finder.
+  /// \brief Override this to register ASTMatchers with \p Finder.
   ///
   /// This should be used by clang-tidy checks that analyze code properties that
   /// dependent on AST knowledge.
   ///
   /// You can register as many matchers as necessary with \p Finder. Usually,
   /// "this" will be used as callback, but you can also specify other callback
   /// classes. Thereby, different matchers can trigger different callbacks.
   ///