This is an archive of the discontinued LLVM Phabricator instance.

Differential D75701

Initialize IsSurrogate
ClosedPublic

Authored by respindola on Mar 5 2020, 10:46 AM.

Details

Reviewers
rsmith
MaskRay
Commits
rGa5704f92b835: [Sema] Initialize IsSurrogate
Summary

This fixes https://bugs.llvm.org/show_bug.cgi?id=45096

Diff Detail

Event Timeline

respindola created this revision.Mar 5 2020, 10:46 AM
respindola added a reviewer: MaskRay.Mar 7 2020, 10:37 AM
MaskRay accepted this revision.Mar 7 2020, 12:22 PM

Confirmed that the patch fixes valgrind clang -cc1 -S -std=c++17 -o native-stack.s native-stack.ii for a -O0 -g Debug build.

-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=on does not have the Conditional jump or move depends on uninitialised value issue.

This revision is now accepted and ready to land.Mar 7 2020, 12:22 PM
Closed by commit rGa5704f92b835: [Sema] Initialize IsSurrogate (authored by • espindola, committed by MaskRay). · Explain WhyMar 7 2020, 12:28 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2020, 12:29 PM

Revision Contents

PathSize
clang/
include/
clang/
Sema/
2 lines

Diff 248545

clang/include/clang/Sema/Overload.h

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines unsigned getNumParams() const {
if (Function) if (Function)
return Function->getNumParams(); return Function->getNumParams();
return ExplicitCallArguments; return ExplicitCallArguments;
} }
private: private:
friend class OverloadCandidateSet; friend class OverloadCandidateSet;
OverloadCandidate() OverloadCandidate()
: IsADLCandidate(CallExpr::NotADL), RewriteKind(CRK_None) {} : IsSurrogate(false), IsADLCandidate(CallExpr::NotADL), RewriteKind(CRK_None) {}
}; };
/// OverloadCandidateSet - A set of overload candidates, used in C++ /// OverloadCandidateSet - A set of overload candidates, used in C++
/// overload resolution (C++ 13.3). /// overload resolution (C++ 13.3).
class OverloadCandidateSet { class OverloadCandidateSet {
public: public:
enum CandidateSetKind { enum CandidateSetKind {
/// Normal lookup. /// Normal lookup.
▲ Show 20 Lines • Show All 259 Lines • Show Last 20 Lines