[hwasan_symbolize] Make hwasan_symbolize compatible with Android fuzzing out-of-box.

[hctim]

Summary

hwasan_symbolize assumes that all the symoblized binaries and DSO's are under $ANDROID_PRODUCT_OUT/symbols. This is not the case
with cc_fuzz targets on Android, as they have fully symbolized binaries and DSO/s under $ANDROID_PRODUCT_OUT/data/fuzz, with
no corresponding entry under /symbols.

Add just the raw $ANDROID_PRODUCT_OUT as a symbol search path.

[eugenis]

compiler-rt/lib/hwasan/scripts/hwasan_symbolize

204

It's not about /data/fuzz specifically. Maybe say that we fallback to $ANDROID_PRODUCT_OUT if the binary can not be found under "symbols" because some targets (ex. fuzzers) install unstripped binaries to the device.

Is this something that should be (could be?) fixed on the Android side? It's the common convention to put unstripped binaries under symbols. Ex. apex generation goes to great lengths to set up paths under symbols/ to match runtime mount path of the apex on device.

[hctim]

compiler-rt/lib/hwasan/scripts/hwasan_symbolize

204

Yeah, agreed. Symbol reexporting available here: https://android-review.googlesource.com/c/platform/build/soong/+/1252144

compiler-rt/lib/hwasan/scripts/hwasan_symbolize

 args = parser.parse_args()
 
 # Unstripped binaries location.
 binary_prefixes = args.symbols or []
 if not binary_prefixes:
   if 'ANDROID_PRODUCT_OUT' in os.environ:
     product_out = os.path.join(os.environ['ANDROID_PRODUCT_OUT'], 'symbols')
     binary_prefixes.append(product_out)
+    # The Android fuzzing `/data/fuzz` out directory contains executables with
+    # symbols.
+    binary_prefixes.append(os.environ['ANDROID_PRODUCT_OUT'])
 
 for p in binary_prefixes:
   if not os.path.isdir(p):
     print >>sys.stderr, "Symbols path does not exist or is not a directory:", p
     sys.exit(1)
 
 # Source location.
 paths_to_cut = args.source or []