Page MenuHomePhabricator

Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block"

Authored by aprantl on Mar 4 2020, 8:38 AM.



Block copy/destroy helpers are now linkonce_odr functions, meant to be uniqued, and thus attaching debug information from one translation unit (or even just from one instance of many inside one translation unit) would be misleading and wrong in the general case.

This effectively reverts commit 9c6b6826ce3720ca8bb9bd15f3abf71261e6b911.


Diff Detail

Event Timeline

aprantl updated this revision to Diff 248190.Mar 4 2020, 8:38 AM
aprantl created this revision.
aprantl updated this revision to Diff 248192.Mar 4 2020, 8:40 AM
vsk added inline comments.Mar 4 2020, 9:10 AM

Should the location on the ret instruction be artificial as well?

aprantl updated this revision to Diff 248285.Mar 4 2020, 12:42 PM

Good catch, and non-obvious resolution.

vsk accepted this revision.Mar 4 2020, 1:21 PM

Nice! Lgtm, thanks.

This revision is now accepted and ready to land.Mar 4 2020, 1:21 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2020, 10:24 AM