[lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts

[teemperor]

Summary

Otherwise this code won't run on the Release+Asserts builds we have on the CI.

Fixes rdar://problem/59867885 (partly)

[aprantl]

lldb/source/Core/Section.cpp

271

remove for debug builds

lldb/source/Core/Section.cpp

if (child_offset <= offset &&
         offset - child_offset <
             child_section->GetByteSize() + (allow_section_end ? 1 : 0))
       return child_section->ResolveContainedAddress(offset - child_offset,
                                                     so_addr, allow_section_end);
   }
   so_addr.SetOffset(offset);
   so_addr.SetSection(const_cast<Section *>(this)->shared_from_this());
 
-#ifdef LLDB_CONFIGURATION_DEBUG
-  // For debug builds, ensure that there are no orphaned (i.e., moduleless)
-  // sections.
+  // Ensure that there are no orphaned (i.e., moduleless) sections.
   assert(GetModule().get());
-#endif
   return true;
 }
 
 bool Section::ContainsFileAddress(addr_t vm_addr) const {
   const addr_t file_addr = GetFileAddress();
   if (file_addr != LLDB_INVALID_ADDRESS && !IsThreadSpecific()) {
     if (file_addr <= vm_addr) {
       const addr_t offset = (vm_addr - file_addr) * m_target_byte_size;

lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

if (log) {
       DumpPacket(log_strm, request_packet.GetData(), request_packet.GetSize());
       LLDB_LOGF(log, "error: kdp running, not sending packet: %.*s",
                 (uint32_t)log_strm.GetSize(), log_strm.GetData());
     }
     return false;
   }
 
   std::lock_guard<std::recursive_mutex> guard(m_sequence_mutex);
-#ifdef LLDB_CONFIGURATION_DEBUG
   // NOTE: this only works for packets that are in native endian byte order
   assert(request_packet.GetSize() ==
          *((const uint16_t *)(request_packet.GetData() + 2)));
-#endif
   lldb::offset_t offset = 1;
   const uint32_t num_retries = 3;
   for (uint32_t i = 0; i < num_retries; ++i) {
     if (SendRequestPacketNoLock(request_packet)) {
       const uint8_t request_sequence_id = (uint8_t)request_packet.GetData()[1];
       while (true) {
         if (WaitForPacketWithTimeoutMicroSecondsNoLock(
                 reply_packet,

lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h

protected:
 
   bool PrivateSetRegisterValue(uint32_t reg, llvm::ArrayRef<uint8_t> data);
 
   bool PrivateSetRegisterValue(uint32_t reg, uint64_t val);
 
   void SetAllRegisterValid(bool b);
 
   bool GetRegisterIsValid(uint32_t reg) const {
-#if defined(LLDB_CONFIGURATION_DEBUG)
     assert(reg < m_reg_valid.size());
-#endif
     if (reg < m_reg_valid.size())
       return m_reg_valid[reg];
     return false;
   }
 
   void SetRegisterIsValid(const RegisterInfo *reg_info, bool valid) {
     if (reg_info)
       return SetRegisterIsValid(reg_info->kinds[lldb::eRegisterKindLLDB],
                                 valid);
   }
 
   void SetRegisterIsValid(uint32_t reg, bool valid) {
-#if defined(LLDB_CONFIGURATION_DEBUG)
     assert(reg < m_reg_valid.size());
-#endif
     if (reg < m_reg_valid.size())
       m_reg_valid[reg] = valid;
   }
 
   GDBRemoteDynamicRegisterInfo &m_reg_info;
   std::vector<bool> m_reg_valid;
   DataExtractor m_reg_data;
   bool m_read_all_at_once;