[lldb][NFC] Minor code cleanup in Editline.cpp

[gedatsu217]

Summary

I simplified a part of the code,

[JDevlieghere]

Thanks for the patch Shu! Next time, please upload the patch with full context. (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

lldb/source/Host/common/Editline.cpp

307

Do we need the (int) cast? If the compiler complains when you remove it, I think a better alternative would be to use std::max<int>(3, ...).

[gedatsu217]

I fixed a little according to your instruction, and I made an additional revision. (I revised type inference.)

[JDevlieghere]

source/Host/common/Editline.cpp

150 ↗

(On Diff #247508)

Please run clang format over your patch. If you add the following file [1] to your path, you can run git clang-format and it will only reformat the staged changes.

[1] https://github.com/llvm/llvm-project/blob/master/clang/tools/clang-format/git-clang-format

[gedatsu217]

Sorry, I revised it.

[JDevlieghere]

Thank you. LGTM

[gedatsu217]

What should I do after this? I think I don't have the right to commit.

[JDevlieghere]

In D75294#1905464, @gedatsu217 wrote:

What should I do after this? I think I don't have the right to commit.

I can commit it for you, but @teemperor asked me to hold off until he's had the chance to take a look.

[teemperor]

Actually this LGTM (Jonas already caught the thing I wanted to complain about) but the commit message needs some improvements:

• The title should contain "[NFC]" (which is short for "No functional change" and just means that you didn't change any functionality here. Makes it easier for people looking for bugs).
• Put a "[lldb]" in front of the title to show that this is just an LLDB commit.
• Maybe a more descriptive title between those two tags such as "Minor code cleanup in Editline.cpp". It should be clear from the title what this commit is doing.

I'll do that here but in the next commit you are on your own for making a good title :).

lldb/source/Host/common/Editline.cpp

   while (start < input.length()) {
     size_t end = input.find('\n', start);
     if (end == std::string::npos) {
-      result.insert(result.end(), input.substr(start));
+      result.push_back(input.substr(start));
       break;
     }
-    result.insert(result.end(), input.substr(start, end - start));
+    result.push_back(input.substr(start,end-start));
     start = end + 1;
   }
   return result;

 // Editline private methods
 
 void Editline::SetBaseLineNumber(int line_number) {
-  std::stringstream line_number_stream;
-  line_number_stream << line_number;
   m_base_line_number = line_number;
   m_line_number_digits =
-      std::max(3, (int)line_number_stream.str().length() + 1);
+      std::max(3, (int)std::to_string(line_number).length() + 1);
 }
 
 std::string Editline::PromptForIndex(int line_index) {
   bool use_line_numbers = m_multiline_enabled && m_base_line_number > 0;
   std::string prompt = m_set_prompt;
-  if (use_line_numbers && prompt.length() == 0) {
+  if (use_line_numbers && prompt.length() == 0)
     prompt = ": ";
-  }
   std::string continuation_prompt = prompt;
   if (m_set_continuation_prompt.length() > 0) {
     continuation_prompt = m_set_continuation_prompt;