This is an archive of the discontinued LLVM Phabricator instance.

Update all CMake files in LLVM to use ADDITIONAL_HEADER_DIRS
ClosedPublic

Authored by zturner on Feb 9 2015, 9:47 PM.

Details

Summary

As of r228670, add_llvm_library() supports the ADDITIONAL_HEADER_DIRS argument. This patch uses this argument on every occurrence of add_llvm_library() in llvm. This should greatly increase the number of header files in your IDE project and make source code browsing generally more pleasant.

I did measure a project load time increase of about 10% on Windows with MSVC 2013. I think this is acceptable for MSVC, but would like some feedback from Xcode people to see if the situation is worse there.

Diff Detail

Event Timeline

zturner updated this revision to Diff 19640.Feb 9 2015, 9:47 PM
zturner retitled this revision from to Update all CMake files in LLVM to use ADDITIONAL_HEADER_DIRS.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a reviewer: beanz.
zturner added a subscriber: Unknown Object (MLST).
beanz accepted this revision.Feb 10 2015, 9:59 AM
beanz edited edge metadata.

LGTM. I'm not a regular Xcode user, but I didn't observe any noticeable slowdown in project loading.

This revision is now accepted and ready to land.Feb 10 2015, 9:59 AM
This revision was automatically updated to reflect the committed changes.