This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Color the current PC marker
ClosedPublic

Authored by JDevlieghere on Feb 24 2020, 12:45 PM.

Details

Summary

Highlight the current PC marker. D75070 does the same thing but for source listings.

Diff Detail

Event Timeline

JDevlieghere created this revision.Feb 24 2020, 12:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2020, 12:45 PM
teemperor accepted this revision.Feb 24 2020, 12:47 PM

This is the best patch I have seen since I started working on LLVM

This revision is now accepted and ready to land.Feb 24 2020, 12:47 PM
This revision was automatically updated to reflect the committed changes.

In D75070 I commented that we might want to allow users to change the ${current-pc-arrow} as a string. It is hard coded to "->", though with all the terminal codes, it might be nice to let this be a setting.