Page MenuHomePhabricator

[Diagnostic] Improve discoverability of ftabstop for misleading indentation
Needs ReviewPublic

Authored by Tyker on Feb 22 2020, 2:45 AM.

Details

Reviewers
eli.friedman
Summary

This adds an additional note after the misleading warning when the code has a mix of tab and space informing about -ftabstop when -ftabstop is used in the generation of the warning.

Diff Detail

Event Timeline

Tyker created this revision.Feb 22 2020, 2:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2020, 2:45 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Tyker added a comment.EditedFeb 22 2020, 2:46 AM

i tried to find a good message for the note but i don't think i succeeded. any suggestions.

jyknight added inline comments.
clang/include/clang/Basic/DiagnosticParseKinds.td
67

Maybe "assuming tabstops every %0 spaces (override with -ftabstop=)"