Page MenuHomePhabricator

[Polly][Refactor] Use only one BlockGenerator for a SCoP
ClosedPublic

Authored by jdoerfert on Feb 6 2015, 6:28 AM.

Details

Summary
This change has two main purposes:
  1) We do not use a static interface to hide an object we create and
     destroy for every basic block we copy.
  2) We allow the BlockGenerator to store information between calls to
     the copyBB method. This will ease scalar/phi code generation
     later on.

While a lot of method signatures were changed this should not cause
any real behaviour change.

Diff Detail

Event Timeline

jdoerfert updated this revision to Diff 19483.Feb 6 2015, 6:28 AM
jdoerfert retitled this revision from to [Polly][Refactor] Use only one BlockGenerator for a SCoP.
jdoerfert updated this object.
jdoerfert added subscribers: Restricted Project, Unknown Object (MLST).

Some notes.

include/polly/CodeGen/BlockGenerators.h
69

I forgot to copy the @param declarionts here.

91

This is part of the next patch and will be removed.

grosser accepted this revision.Feb 6 2015, 6:59 AM
grosser edited edge metadata.

Hi,

this looks generally good to me.

Tobias

include/polly/CodeGen/BlockGenerators.h
120

The documentation is not consistent in this class, but it may still be good to document the newly added parameter here (same below).

This revision is now accepted and ready to land.Feb 6 2015, 6:59 AM
jdoerfert closed this revision.Feb 6 2015, 1:44 PM

commited in r228443.