Page MenuHomePhabricator

Fix the LLDB build under Debian Kfreebsd
ClosedPublic

Authored by sylvestre.ledru on Feb 5 2015, 8:35 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sylvestre.ledru retitled this revision from to Fix the LLDB build under Debian Kfreebsd.
sylvestre.ledru updated this object.
sylvestre.ledru edited the test plan for this revision. (Show Details)
sylvestre.ledru added a reviewer: emaste.
sylvestre.ledru added a subscriber: Unknown Object (MLST).
hans added a subscriber: hansw.Feb 5 2015, 11:30 AM
emaste edited edge metadata.Feb 9 2015, 12:32 PM

LGTM other than sorting the lists in alpha order. In the future would you mind uploading with full context (e.g., using -U99999)?

source/Host/common/Host.cpp
1057 ↗(On Diff #19411)

Do you mind re-sorting these in alpha order? Minor point, but I think it would make things more clear when future changes come along (e.g. adding OpenBSD or refactoring this into some catch-all #define)

LGTM other than sorting the lists in alpha order. In the future would you mind uploading with full context (e.g., using -U99999)?

This revision was automatically updated to reflect the committed changes.

With the correct ordering!