This is an archive of the discontinued LLVM Phabricator instance.

Differential D74266

[lldb-vscode] remove deprecated trace option
ClosedPublic

Authored by wallace on Feb 7 2020, 4:28 PM.

Details

Reviewers
clayborg
Commits
rGbd62c9cecf34: [lldb-vscode] remove deprecated trace option
Summary

This option is not used anymore and has been replaced by the env var LLDBVSCODE_LOG.

Diff Detail

Event Timeline

wallace created this revision.Feb 7 2020, 4:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2020, 4:28 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B45995: Diff 243316.Feb 7 2020, 4:32 PM
clayborg accepted this revision.Feb 7 2020, 4:45 PM

Originally this was going to enable logging to "/tmp/vscode.txt", but it is hard to log something when many packets have already gone by before sending the "launch" or "attach" requests. So this "trace" never got used. Now logging packets to a file is controlled by the LLDBVSCODE_LOG env var that the spawning process can set if logging is desired.

This revision is now accepted and ready to land.Feb 7 2020, 4:45 PM
Closed by commit rGbd62c9cecf34: [lldb-vscode] remove deprecated trace option (authored by Walter Erquinigo <waltermelon@fb.com>). · Explain WhyFeb 7 2020, 4:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
tools/
lldb-vscode/
10 lines

Diff 243321

lldb/tools/lldb-vscode/package.json

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines "debuggers": [
"description": "Expand program arguments as a shell would without actually launching the program in a shell.", "description": "Expand program arguments as a shell would without actually launching the program in a shell.",
"default": false "default": false
}, },
"detachOnError": { "detachOnError": {
"type": "boolean", "type": "boolean",
"description": "Detach from the program.", "description": "Detach from the program.",
"default": false "default": false
}, },
"trace": {
"type": "boolean",
"description": "Enable logging of the Debug Adapter Protocol.",
"default": true
},
"sourcePath": { "sourcePath": {
"type": "string", "type": "string",
"description": "Specify a source path to remap \"./\" to allow full paths to be used when setting breakpoints in binaries that have relative source paths." "description": "Specify a source path to remap \"./\" to allow full paths to be used when setting breakpoints in binaries that have relative source paths."
}, },
"sourceMap": { "sourceMap": {
"type": "array", "type": "array",
"description": "Specify an array of path remappings; each element must itself be a two element array containing a source and desination pathname. Overrides sourcePath.", "description": "Specify an array of path remappings; each element must itself be a two element array containing a source and desination pathname. Overrides sourcePath.",
"default": [] "default": []
Show All 37 Lines "debuggers": [
], ],
"description": "System process ID to attach to." "description": "System process ID to attach to."
}, },
"waitFor": { "waitFor": {
"type": "boolean", "type": "boolean",
"description": "If set to true, then wait for the process to launch by looking for a process with a basename that matches `program`. No process ID needs to be specified when using this flag.", "description": "If set to true, then wait for the process to launch by looking for a process with a basename that matches `program`. No process ID needs to be specified when using this flag.",
"default": true "default": true
}, },
"trace": {
"type": "boolean",
"description": "Enable logging of the Debug Adapter Protocol.",
"default": true
},
"sourcePath": { "sourcePath": {
"type": "string", "type": "string",
"description": "Specify a source path to remap \"./\" to allow full paths to be used when setting breakpoints in binaries that have relative source paths." "description": "Specify a source path to remap \"./\" to allow full paths to be used when setting breakpoints in binaries that have relative source paths."
}, },
"sourceMap": { "sourceMap": {
"type": "array", "type": "array",
"description": "Specify an array of path remappings; each element must itself be a two element array containing a source and desination pathname. Overrides sourcePath.", "description": "Specify an array of path remappings; each element must itself be a two element array containing a source and desination pathname. Overrides sourcePath.",
"default": [] "default": []
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines