This is an archive of the discontinued LLVM Phabricator instance.

Removing SVN download of LIT due to MonoRepo
AcceptedPublic

Authored by drew_maxwell on Feb 6 2020, 3:10 PM.

Details

Reviewers
cmatthews
azhar
Summary

Removing need to acquire LIT via SVN copy, as LIT is now provided in the MonoRepo.

Diff Detail

Event Timeline

drew_maxwell created this revision.Feb 6 2020, 3:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2020, 3:10 PM
cmatthews requested changes to this revision.Feb 7 2020, 11:54 AM

How is the lit requirement no longer needed? This URL does not work, but the we still require lit to be installed for the system to work. I think this needed to be updated to fetch the latest lit from the GitHub repo.

This revision now requires changes to proceed.Feb 7 2020, 11:54 AM

Where does this file come from?

lit is packaged on pypi, would it work to get it from there?

cmatthews added a comment.EditedFeb 7 2020, 3:35 PM

In the past there has been rev lock between LNT and LIT, so we try to fetch the most up to date lit we can. The pypi version can be quite out of date.

drew_maxwell updated this revision to Diff 243310.EditedFeb 7 2020, 3:56 PM

Replaced SVN checkout with installation via current updated Monorepo

cmatthews requested changes to this revision.Feb 7 2020, 4:06 PM

Can you remove the commented out old line. Otherwise, LGTM.

This revision now requires changes to proceed.Feb 7 2020, 4:06 PM

Removed previously commented-out line.

drew_maxwell set the repository for this revision to rG LLVM Github Monorepo.

Removed the errant mypatch.patch file from the previous commit.

Confirmed removal of SVN line from requirements.client.txt. Removed reference from comment as well.

Just to confirm, you are using git+git not git+https?

Just to confirm, you are using git+git not git+https?

Both were tested successfully. Either one could be used; is there a preference?

Changed protocol used from Git to HTTPS.

This revision is now accepted and ready to land.Feb 13 2020, 1:27 PM