Page MenuHomePhabricator

[LLVM] Please could you review my patches to add Cortex-A72 support to LLVM.
ClosedPublic

Authored by rs on Feb 4 2015, 4:24 AM.

Details

Reviewers
rengolin
Summary

The patches add support to LLVM for targeting the Cortex-A72 processor. Currently, Cortex-A72 is modelled as an Cortex-A57 except the fp load balancing pass isn't enabled for Cortex-A72 as it's not profitable to have it enabled for this core.

Tests for Cortex-A72 are also added.

Diff Detail

Event Timeline

rs updated this revision to Diff 19312.Feb 4 2015, 4:24 AM
rs retitled this revision from to [LLVM] Please could you review my patches to add Cortex-A72 support to LLVM..
rs updated this object.
rs edited the test plan for this revision. (Show Details)
rs added a subscriber: Unknown Object (MLST).
rengolin accepted this revision.Feb 4 2015, 5:14 AM
rengolin added a reviewer: rengolin.
rengolin added a subscriber: rengolin.

LGTM, thanks! Please commit this one before the Clang patch.

cheers,
--renato

lib/Target/AArch64/AArch64.td
94

I think this is ok until we know more about the core.

This revision is now accepted and ready to land.Feb 4 2015, 5:14 AM
rs added a comment.Feb 4 2015, 5:16 AM

LGTM, thanks! Please commit this one before the Clang patch.

cheers,
--renato

Again thanks for the reviews.

I don't have commit access so could you please commit the llvm and the clang patches?

rengolin closed this revision.Feb 4 2015, 5:33 AM

r228140