Page MenuHomePhabricator

[sanitizer] Add missing declarations for sigaltstack syscall wrappers.
ClosedPublic

Authored by eugenis on Feb 4 2020, 12:22 PM.

Diff Detail

Event Timeline

eugenis created this revision.Feb 4 2020, 12:22 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 4 2020, 12:22 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Unit tests: unknown.

clang-tidy: fail. clang-tidy found 0 errors and 7 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

rupprecht accepted this revision.Feb 4 2020, 1:05 PM
rupprecht added a subscriber: rupprecht.
rupprecht added inline comments.
compiler-rt/include/sanitizer/linux_syscall_hooks.h
3080–3081

LGTM with a change to longs:

void __sanitizer_syscall_pre_impl_sigaltstack(long ss, long oss);
void __sanitizer_syscall_post_impl_sigaltstack(long res, long ss, long oss);
This revision is now accepted and ready to land.Feb 4 2020, 1:05 PM
eugenis updated this revision to Diff 242412.Feb 4 2020, 1:09 PM

fix argument types + add a test

Unit tests: unknown.

clang-tidy: fail. clang-tidy found 0 errors and 7 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

This revision was automatically updated to reflect the committed changes.