This is an archive of the discontinued LLVM Phabricator instance.

[gn] Paper over Py3 urllib2 incompatibility in gn/get.py
ClosedPublic

Authored by rnk on Jan 22 2020, 2:33 PM.

Diff Detail

Event Timeline

rnk created this revision.Jan 22 2020, 2:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 2:33 PM

Unit tests: pass. 62112 tests passed, 0 failed and 808 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

thakis accepted this revision.Jan 25 2020, 8:36 PM
thakis added inline comments.
llvm/utils/gn/get.py
12

Maybe try the py3 way first and then import the py2 as replacement, and move the script to use the py3 name.

This revision is now accepted and ready to land.Jan 25 2020, 8:36 PM
This revision was automatically updated to reflect the committed changes.