This is an archive of the discontinued LLVM Phabricator instance.

Differential D73163

[Object][test] - Remove readobj-elf-versioning.test and support files.
ClosedPublic

Authored by grimar on Jan 22 2020, 1:53 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rG46acce42b322: [Object][test] - Remove readobj-elf-versioning.test and support files.
Summary

readobj-elf-versioning.test was added in rL152436 and
checks how llvm-readobj --dyn-syms prints versioned symbols.
We test the same in llvm-readobj\ELF\dyn-symbols.test currently.

This patch removes the test and 4 more support files from Inputs.

Diff Detail

Event Timeline

grimar created this revision.Jan 22 2020, 1:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 1:53 AM
grimar mentioned this in D73164: [llvm-readobj][test] - Add a check for --dyn-syms..Jan 22 2020, 2:15 AM
MaskRay accepted this revision.Jan 22 2020, 11:42 AM
This revision is now accepted and ready to land.Jan 22 2020, 11:42 AM
Closed by commit rG46acce42b322: [Object][test] - Remove readobj-elf-versioning.test and support files. (authored by grimar). · Explain WhyJan 23 2020, 1:16 AM
This revision was automatically updated to reflect the committed changes.
grimar mentioned this in rG5f6ff716417a: [llvm-readobj][test] - Add a check for --dyn-syms..Jan 23 2020, 1:25 AM

Revision Contents

Diff 239806

llvm/test/Object/Inputs/elf-versioning-test.i386

  • This binary file was deleted.
PropertyOld ValueNew Value
File Mode100755null

llvm/test/Object/Inputs/elf-versioning-test.x86_64

  • This binary file was deleted.
PropertyOld ValueNew Value
File Mode100755null

llvm/test/Object/Inputs/elfver.S

  • This file was deleted.
# Compile with:
# ARGS="-shared -nostdlib -Wl,--version-script=elfver.script"
# clang $ARGS -m32 elfver.S -lc -o elf-versioning-test.i386
# clang $ARGS -m64 elfver.S -lc -o elf-versioning-test.x86_64
# Also, strip off non-dynamic symbols:
# strip elf-versioning-test.i386
# strip elf-versioning-test.x86_64
#ifdef __i386__
.symver _puts, puts@GLIBC_2.0
#else
.symver _puts, puts@GLIBC_2.2.5
#endif
call _puts@PLT
.symver foo1, foo@VER1
.globl foo1
.type foo1, @function
foo1:
ret
.symver foo2, foo@@VER2
.globl foo2
.type foo2, @function
foo2:
ret
.globl unversioned_define
.type unversioned_define, @function
unversioned_define:

llvm/test/Object/Inputs/elfver.script

  • This file was deleted.
VER1 {
global:
foo;
};
VER2 {
global:
foo;
} VER1;

llvm/test/Object/readobj-elf-versioning.test

  • This file was deleted.
RUN: llvm-readobj --dyn-syms %p/Inputs/elf-versioning-test.i386 \
RUN: | FileCheck %s -check-prefix ELF
RUN: llvm-readobj --dyn-syms %p/Inputs/elf-versioning-test.i386 \
RUN: | FileCheck %s -check-prefix ELF32
RUN: llvm-readobj --dyn-syms %p/Inputs/elf-versioning-test.x86_64 \
RUN: | FileCheck %s -check-prefix ELF
RUN: llvm-readobj --dyn-syms %p/Inputs/elf-versioning-test.x86_64 \
RUN: | FileCheck %s -check-prefix ELF64
ELF: DynamicSymbols [
ELF: Symbol {
ELF: Name: foo@@VER2
ELF: Binding: Global
ELF: Type: Function
ELF: Section: .text
ELF: }
ELF: Symbol {
ELF: Name: foo@VER1
ELF: Binding: Global
ELF: Type: Function
ELF: Section: .text
ELF: }
ELF: Symbol {
ELF: Name: unversioned_define
ELF: Binding: Global
ELF: Type: Function
ELF: Section: .text
ELF: }
ELF: ]
ELF32: DynamicSymbols [
ELF32: Symbol {
ELF32: Name: puts@GLIBC_2.0
ELF32: Binding: Global
ELF32: Type: Function
ELF32: Section: Undefined (0x0)
ELF32: }
ELF32: ]
ELF64: DynamicSymbols [
ELF64: Symbol {
ELF64: Name: puts@GLIBC_2.2.5
ELF64: Binding: Global
ELF64: Type: Function
ELF64: Section: Undefined (0x0)
ELF64: }
ELF64: ]
llvm/test/Object/Inputs/elfver.S