Page MenuHomePhabricator

[libcxx] Don't assume LIT_EXECUTABLE points to a Python script
ClosedPublic

Authored by garious on Jan 31 2015, 9:23 AM.

Details

Summary

lit.py's shebang allows it to masquerade as an executable. The
CMake build ignores that and assumes it is a Python script. If
LIT_EXECUTABLE was actually an executable, the build would fall
over.

This patch cleans things up. It assumes LIT_EXECUTABLE is
an actual executable. If it is a Python script, we'll use its
shebang to find a Python interpreter.

Diff Detail

Repository
rL LLVM

Event Timeline

garious updated this revision to Diff 19096.Jan 31 2015, 9:23 AM
garious retitled this revision from to [libcxx] Don't assume LIT_EXECUTABLE points to a Python script.
garious updated this object.
garious edited the test plan for this revision. (Show Details)
garious added a reviewer: mclow.lists.
garious set the repository for this revision to rL LLVM.
garious added a subscriber: Unknown Object (MLST).
mclow.lists accepted this revision.Feb 2 2015, 4:38 PM
mclow.lists edited edge metadata.

This looks fine to me.

This revision is now accepted and ready to land.Feb 2 2015, 4:38 PM
danalbert accepted this revision.Feb 2 2015, 4:49 PM
danalbert added a reviewer: danalbert.
danalbert added a subscriber: danalbert.

LGTM.

This revision was automatically updated to reflect the committed changes.