This is an archive of the discontinued LLVM Phabricator instance.

Remove invalid const qualifier for r0, since it is written by svc.
ClosedPublic

Authored by srhines on Jan 30 2015, 3:32 PM.

Reviewers

Commits

Summary

This causes an invalid lvalue error when building for Android.

srhines retitled this revision from to Remove invalid const qualifier for r0, since it is written by svc. .

srhines updated this object.

srhines edited the test plan for this revision. (Show Details)

srhines added a reviewer: danalbert.

srhines added a subscriber: Unknown Object (MLST).

LGTM.

This revision is now accepted and ready to land.Jan 30 2015, 3:36 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

builtins/

2 lines

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines	#elif defined(__arm__) && !defined(__APPLE__)
#if defined(__FreeBSD__) \|\| defined(__NetBSD__)		#if defined(__FreeBSD__) \|\| defined(__NetBSD__)
struct arm_sync_icache_args arg;		struct arm_sync_icache_args arg;

arg.addr = (uintptr_t)start;		arg.addr = (uintptr_t)start;
arg.len = (uintptr_t)end - (uintptr_t)start;		arg.len = (uintptr_t)end - (uintptr_t)start;

sysarch(ARM_SYNC_ICACHE, &arg);		sysarch(ARM_SYNC_ICACHE, &arg);
#elif defined(__ANDROID__)		#elif defined(__ANDROID__)
const register int start_reg __asm("r0") = (int) (intptr_t) start;		register int start_reg __asm("r0") = (int) (intptr_t) start;
const register int end_reg __asm("r1") = (int) (intptr_t) end;		const register int end_reg __asm("r1") = (int) (intptr_t) end;
const register int flags __asm("r2") = 0;		const register int flags __asm("r2") = 0;
const register int syscall_nr __asm("r7") = __ARM_NR_cacheflush;		const register int syscall_nr __asm("r7") = __ARM_NR_cacheflush;
__asm __volatile("svc 0x0" : "=r"(start_reg)		__asm __volatile("svc 0x0" : "=r"(start_reg)
: "r"(syscall_nr), "r"(start_reg), "r"(end_reg), "r"(flags) : "r0");		: "r"(syscall_nr), "r"(start_reg), "r"(end_reg), "r"(flags) : "r0");
if (start_reg != 0) {		if (start_reg != 0) {
compilerrt_abort();		compilerrt_abort();
}		}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines