Page MenuHomePhabricator

[ASan] Add use_madv_dontdump flag.

Authored by ygribov on Jan 30 2015, 5:57 AM.



This patch implements use_madv_dontdump flag suggested in . The flag disables dumping of shadow memory to corefile (which takes hours on 64-bit platforms). Tested on Linux x64.

I didn't add a testcase - generating a predictable corefile is hard given the zoo of modern crash reporters. E.g. see (Apport from stock Ubuntu 14 multiples core limit by 1000).

Diff Detail


Event Timeline

ygribov updated this revision to Diff 19035.Jan 30 2015, 5:57 AM
ygribov retitled this revision from to [ASan] Add use_madv_dontdump flag..
ygribov updated this object.
ygribov edited the test plan for this revision. (Show Details)
ygribov added reviewers: kcc, samsonov.
ygribov set the repository for this revision to rL LLVM.
ygribov added a subscriber: Unknown Object (MLST).

Perhaps also disable_core=0 on 64-bit in this patch?

kcc added inline comments.Jan 30 2015, 8:50 AM
80 ↗(On Diff #19035)

Please move the flag to sanitizer_common.
Even if you then use it only in asan, we may later want to use it in msan/tsan
(but you are welcome to implement that too, of course)

ygribov updated this revision to Diff 19129.Feb 2 2015, 12:08 AM

Also implement for MSan and TSan.

kcc accepted this revision.Feb 2 2015, 11:16 AM
kcc edited edge metadata.


This revision is now accepted and ready to land.Feb 2 2015, 11:16 AM
This revision was automatically updated to reflect the committed changes.