This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Minor update to testcase for Z / (1.0 / Y) => (Y * Z)
ClosedPublic

Authored by raghesh on Jan 8 2020, 7:25 PM.

Download Raw Diff

Details

Reviewers

spatel
craig.topper

Commits

rG032a9393a739: [InstCombine] Use minimal FMF in testcase for Z / (1.0 / Y) => (Y * Z); NFC

Summary

Changing the flag 'fast' to 'reassoc arcp'. This is done to use the minimal required subset of flags.

Diff Detail

Event Timeline

raghesh created this revision.Jan 8 2020, 7:25 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2020, 7:25 PM

LGTM

This revision is now accepted and ready to land.Jan 9 2020, 5:19 AM

Closed by commit rG032a9393a739: [InstCombine] Use minimal FMF in testcase for Z / (1.0 / Y) => (Y * Z); NFC (authored by spatel). · Explain WhyJan 9 2020, 5:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

test/

Transforms/

InstCombine/

fdiv.ll

4 lines

Diff 236950

llvm/test/Transforms/InstCombine/fdiv.ll

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines	;
ret float %div2		ret float %div2
}		}

; Z / (1.0 / Y)		; Z / (1.0 / Y)

define float @div_with_div_denominator_with_one_as_numerator_extra_use(float %x, float %y, float %z) {		define float @div_with_div_denominator_with_one_as_numerator_extra_use(float %x, float %y, float %z) {
; CHECK-LABEL: @div_with_div_denominator_with_one_as_numerator_extra_use(		; CHECK-LABEL: @div_with_div_denominator_with_one_as_numerator_extra_use(
; CHECK-NEXT: [[DIV1:%.]] = fdiv float 1.000000e+00, [[Y:%.]]		; CHECK-NEXT: [[DIV1:%.]] = fdiv float 1.000000e+00, [[Y:%.]]
; CHECK-NEXT: [[DIV2:%.]] = fdiv fast float [[Z:%.]], [[DIV1]]		; CHECK-NEXT: [[DIV2:%.]] = fdiv reassoc arcp float [[Z:%.]], [[DIV1]]
; CHECK-NEXT: call void @use_f32(float [[DIV1]])		; CHECK-NEXT: call void @use_f32(float [[DIV1]])
; CHECK-NEXT: ret float [[DIV2]]		; CHECK-NEXT: ret float [[DIV2]]
;		;
%div1 = fdiv float 1.0, %y		%div1 = fdiv float 1.0, %y
%div2 = fdiv fast float %z, %div1		%div2 = fdiv reassoc arcp float %z, %div1
call void @use_f32(float %div1)		call void @use_f32(float %div1)
ret float %div2		ret float %div2
}		}

define float @fneg_fneg(float %x, float %y) {		define float @fneg_fneg(float %x, float %y) {
; CHECK-LABEL: @fneg_fneg(		; CHECK-LABEL: @fneg_fneg(
; CHECK-NEXT: [[DIV:%.]] = fdiv float [[X:%.]], [[Y:%.*]]		; CHECK-NEXT: [[DIV:%.]] = fdiv float [[X:%.]], [[Y:%.*]]
; CHECK-NEXT: ret float [[DIV]]		; CHECK-NEXT: ret float [[DIV]]
▲ Show 20 Lines • Show All 364 Lines • Show Last 20 Lines