This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix gcc 5.5 build break
AbandonedPublic

Authored by asaadaldien on Jan 3 2020, 11:49 AM.

Details

Reviewers
nicolasvasilache

Diff Detail

Event Timeline

asaadaldien created this revision.Jan 3 2020, 11:49 AM
rriddle added inline comments.Jan 3 2020, 12:04 PM
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
101

Have you checked to see if this actually fixes the issue? Last time I ran into this, I had to explicitly wrap the def in:

namespace ... {

}

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480

Pushing a patch that wraps in the namespace as Jacques and River suggested.

mlir/lib/Dialect/Linalg/Utils/Utils.cpp
101

I submitted this as a hotpatch and you're right.
Problem is that we can't get easy access to a gcc-5 ..
Jacques tested the wrapper version through docker and it works, sending another hotpatch now.

This should be unnecessary now.