Page MenuHomePhabricator

Remove support for pnaclcall attribute
ClosedPublic

Authored by dschuff on Jan 27 2015, 11:50 AM.

Details

Summary

Remove support for pnaclcall attribute

It was used for interoperability with PNaCl's calling conventions, but
it's no longer needed.

Diff Detail

Repository
rL LLVM

Event Timeline

dschuff updated this revision to Diff 18834.Jan 27 2015, 11:50 AM
dschuff retitled this revision from to Remove support for pnaclcall attribute.
dschuff updated this object.
dschuff edited the test plan for this revision. (Show Details)
dschuff added a reviewer: jvoung.
dschuff added a subscriber: Unknown Object (MLST).
dschuff updated this object.Jan 27 2015, 11:52 AM
dschuff added a subscriber: rafael.
jfb accepted this revision.Jan 27 2015, 11:41 PM
jfb added a reviewer: jfb.

As Aaron pointed out it's probably better to keep other enum values the same and leave a placeholder here PnaclCall was until the next major rev.

lgtm otherwise.

This revision is now accepted and ready to land.Jan 27 2015, 11:41 PM
jvoung edited edge metadata.Jan 28 2015, 8:54 AM

Otherwise LGTM too.

lib/CodeGen/TargetInfo.cpp
3103 ↗(On Diff #18834)

The ' // Used for everything else' comments here and in the ARM version can be removed too.

Actually, can just the plain X86_64ABIInfo be used where NaClX86_64ABIInfo was, and the latter removed too? Same for ARM.

dschuff updated this revision to Diff 18908.Jan 28 2015, 11:10 AM
dschuff edited edge metadata.
  • Remove NaCl*ABIInfo

it just existed to delegate to either the portable or native ABIInfo
also remove checkCallingConvention which was now a no-op override.

include/clang-c/Index.h
2857 ↗(On Diff #18834)

Removed entirely and left a placeholder comment.

lib/CodeGen/TargetInfo.cpp
3103 ↗(On Diff #18834)

Yes, Done.
NaCX86_64TargetCodegenInfo can maybe go away too in favor of the vanilla x86_64 one. But there are a couple of differences which I want to test so I'll defer that to another CL.

jvoung accepted this revision.Jan 28 2015, 11:32 AM
jvoung edited edge metadata.
This revision was automatically updated to reflect the committed changes.