Page MenuHomePhabricator

[SystemZ] Use FNeg in s390x clang builtins
ClosedPublic

Authored by kpn on Dec 24 2019, 6:06 AM.

Details

Summary

The s390x builtins are still using FSub instead of FNeg. Correct that.

Diff Detail

Event Timeline

kpn created this revision.Dec 24 2019, 6:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 24 2019, 6:06 AM
uweigand requested changes to this revision.Dec 24 2019, 6:26 AM

This also needs updating the test cases that are testing for the old behavior:

Failing Tests (4):

Clang :: CodeGen/builtins-systemz-vector.c
Clang :: CodeGen/builtins-systemz-vector2.c
Clang :: CodeGen/builtins-systemz-zvector.c
Clang :: CodeGen/builtins-systemz-zvector2.c
This revision now requires changes to proceed.Dec 24 2019, 6:26 AM

Otherwise this LGTM. Thanks for taking care of those!

kpn updated this revision to Diff 235880.Jan 2 2020, 8:00 AM

Update now-failing tests.

uweigand accepted this revision.Jan 2 2020, 8:37 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 2 2020, 8:37 AM
kpn closed this revision.Jan 2 2020, 9:18 AM

My pleasure!

Closed with commit 89d6c288ba5adb20d92142e9425f7ab79b8f159e.