This is an archive of the discontinued LLVM Phabricator instance.

Add the 'start' and 'length' to the completions response.
Needs ReviewPublic

Authored by ivanhernandez13 on Dec 22 2019, 6:58 PM.

Details

Reviewers
clayborg
Summary

Add the 'start' and 'length' to the completions response. This will fix an issue where applying a completion 'foo.bar' to 'po foo.b' inserts the entire completion resulting in 'po foo.foo.bar'.

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2019, 6:58 PM
ivanhernandez13 retitled this revision from Add the 'start' and 'length' to the completions response. This will fix an issue where applying a completion 'foo.bar' to 'po foo.b' inserts the entire completion resulting in 'po foo.foo.bar'. to Add the 'start' and 'length' to the completions response..Dec 22 2019, 6:59 PM
ivanhernandez13 edited the summary of this revision. (Show Details)
labath added a subscriber: labath.

This needs a test case, but I am also not sure that the implementation is correct even.
What will this do with multiword commands "frame variable foo.b<TAB>" ? Or even single-word commands that have multiple arguments ("vo foo bar foo.b<TAB>")?