This is an archive of the discontinued LLVM Phabricator instance.

[lldb][NFC] Remove all `setUp` overrides that only call the parent implementation
ClosedPublic

Authored by teemperor on Dec 13 2019, 12:58 AM.

Details

Summary

A lot of our tests copied the setUp code from our TestSampleTest.py:

def setUp(self):
    # Call super's setUp().
    TestBase.setUp(self)

This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions.

Diff Detail

Event Timeline

teemperor created this revision.Dec 13 2019, 12:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2019, 12:58 AM
labath accepted this revision.Dec 13 2019, 3:00 AM

Yes, these are really annoying. Maybe it would be also good to add some language to TestSampleTest to say that you should only define this method if you actually want to do some work there..

This revision is now accepted and ready to land.Dec 13 2019, 3:00 AM
This revision was automatically updated to reflect the committed changes.