non-Unicode response file support on Windows

[ygao]

Summary

Hi community,
I have a customer who wants to use Japanese characters in the response
file (Shift-JIS encoded) on Windows. I am attempting to implement it in
lib/Support. It would be very helpful if someone can take a look and give
some feedback.
Thanks in advance,

• Gao

[• rafael]

The main issue I think is that there is not a lot of precedent for this on windows:

• GNU tools only use the local codepage, but that is probably a consequence of simplistically using the crt read function.
• Clang support UTF-16 and UTF-8.
• Microsoft own tools require UTF-16.

The part of this patch that I don't expect to be controversial is skipping the utf-8 bom if one is present. Can you move that to an independent patch?

Also, it needs a testcase. Something as simple an running llvm-as @file_with_utf8_bom should do.

llvm/lib/Support/ConvertUTFWrapper.cpp

90 ↗

(On Diff #18647)

This can be a static helper in CommandLine.cpp.

97 ↗

(On Diff #18647)

This can be a static helper in CommandLine.cpp

[rnk]

The main change here is that BOM-less response files on Windows will use the current codepage rather than defaulting to UTF-8. That seems unfortunate, as it does not promote "UTF8 everywhere", but it's probably the more Windows-y thing to do.

[majnemer]

I agree with Rafael, this behavior would be out of line with other tools. Perhaps an even strange side effect of this change would be us assuming the current code page for response files but not source files, a strange exception.

Assuming that the file is in codepage encoding instead of UTF-8 sounds like a step backwards.

[ygao]

Hi Rafael, Reid, David, thanks for the reviews. I separated the UTF-8 BOM part of the patch into D7156.
It sounds like the support for Shift-JIS encoded files may be specific only to Sony platforms, is that true? I am kinda curious to hear from someone developing in Japanese environment. In writing the original patch, I was making the assumption that if a text file on Windows does not start with the BOM sequence, then it is using the current codepage. That seems to be the case for files created from Notepad, but of course these files can be created from many different sources. If this assumption is not valid, then I wonder what would be a good way to differentiate a UTF-8 file from a current-codepage one; maybe a command-line option?
Thoughts and advice are appreciated,

• Gao

[ygao]

From: Rafael Espíndola [mailto:[e-mail]]
Sent: Friday, January 23, 2015 4:07 PM
Thanks for splitting the patch!
When Rafael Auler implemented the bits for *writing* response files from clang, I think the observed behavior was

• GNU tools use the current codepage.
• MS Tools use UTF-16 only.
• Clang uses UTF-16 or UTF-8 (non-BOM)

The first part of you patch adds support for UTF-8 BOM, which I think is a strict improvement.
The change to assume current codepage in a tool that can handle utf is what I think is problematic, since there is no precedent for it (that I know of).
Response files are small (relative to the work they cause), so maybe one options would be to try to check if the file is UTF-8 and fallback to current codepage if that fails.

I think I just found Rafael Auler’s commit, r217792 (right?). And I confirm that mingw on Windows (tested with MinGW-W64 4.9.2) accepts system codepage-encoded response files (but not UTF-8). I guess what's new here is to try to support both UTF-8 and system codepage.

[silvas]

In D7133#113113, @ygao wrote:

From: Rafael Espíndola [mailto:[e-mail]]
Sent: Friday, January 23, 2015 4:07 PM
Thanks for splitting the patch!
When Rafael Auler implemented the bits for *writing* response files from clang, I think the observed behavior was

• GNU tools use the current codepage.
• MS Tools use UTF-16 only.
• Clang uses UTF-16 or UTF-8 (non-BOM)

The first part of you patch adds support for UTF-8 BOM, which I think is a strict improvement.
The change to assume current codepage in a tool that can handle utf is what I think is problematic, since there is no precedent for it (that I know of).
Response files are small (relative to the work they cause), so maybe one options would be to try to check if the file is UTF-8 and fallback to current codepage if that fails.

I think I just found Rafael Auler’s commit, r217792 (right?). And I confirm that mingw on Windows (tested with MinGW-W64 4.9.2) accepts system codepage-encoded response files (but not UTF-8). I guess what's new here is to try to support both UTF-8 and system codepage.

So why is this patch needed for Shift-JIS then? Wouldn't Shift-JIS be the system codepage?

[rafaelauler]

Yes, but Clang assumes UTF-8 (Windows or Linux) when no BOM is present. So, even though the system code page is Japanese, when Clang opens input files, it will use a function that interprets the file name strings as UTF8.

Modern Windows applications should always use UTF-16. In the Windows API, to use functions that uses the old system code page you must explicitly call functions with the suffix A (ansi), while the recommended functions for internationalization support ends with W (wide) (this transition began back in Windows 95!). I was surprised to see that GNU tools needed files in system code page. IIRC VS tools will always use UTF16.

[silvas]

Oh, I think I misinterpreted gao's comment as being about clang, but now that I reread it, it is about mingw (and not clang running on mingw or whatever I thought he said).

[ygao]

maybe one options would be to try to check if the file is UTF-8 and fallback to current codepage if that fails.

Cleaned up and rebased the patch.
I figured that what Rafael (Espindola) meant earlier is probably to run isLegalUTF8String() before making the assumption about the system code page?

llvm/lib/Support/CommandLine.cpp

 #include <cstdlib>
 #include <map>
 #include <system_error>
+
+#ifdef LLVM_ON_WIN32
+#include "Windows/WindowsSupport.h"
+#undef max
+#undef min
+#endif
+
 using namespace llvm;
 using namespace cl;
 

           S[0] == '\xef' && S[1] == '\xbb' && S[2] == '\xbf');
 }
 
+#ifdef LLVM_ON_WIN32
+// Convert system-locale encoded string to UTF8
+static bool convertANSIToUTF8String(ArrayRef<char> SrcBytes, std::string &Out) {
+  assert(Out.empty());
+
+  if (SrcBytes.empty())
+    return true;
+
+  SmallVector<wchar_t, 128> utf16;
+  SmallVector<char, 128> utf8;
+
+  int len = ::MultiByteToWideChar(CP_ACP, MB_ERR_INVALID_CHARS, SrcBytes.data(),
+                                  SrcBytes.size(), utf16.begin(), 0);
+  if (len == 0)
+    return false;
+
+  utf16.reserve(len + 1);
+  utf16.set_size(len);
+
+  len = ::MultiByteToWideChar(CP_ACP, MB_ERR_INVALID_CHARS, SrcBytes.data(),
+                              SrcBytes.size(), utf16.begin(), utf16.size());
+  if (len == 0)
+    return false;
+
+  len = ::WideCharToMultiByte(CP_UTF8, 0, utf16.begin(), utf16.size(),
+                              utf8.begin(), 0, nullptr, nullptr);
+  if (len == 0)
+    return false;
+
+  utf8.reserve(len + 1);
+  utf8.set_size(len);
+
+  len = ::WideCharToMultiByte(CP_UTF8, 0, utf16.begin(), utf16.size(),
+                              utf8.data(), utf8.size(), nullptr, nullptr);
+  if (len == 0)
+    return false;
+
+  Out.resize(utf8.size());
+  std::copy(utf8.begin(), utf8.end(), Out.begin());
+  return true;
+}
+#endif // LLVM_ON_WIN32
+
 static bool ExpandResponseFile(const char *FName, StringSaver &Saver,
                                TokenizerCallback Tokenizer,
                                SmallVectorImpl<const char *> &NewArgv,

   // Reference: http://en.wikipedia.org/wiki/UTF-8#Byte_order_mark
   else if (hasUTF8ByteOrderMark(BufRef))
     Str = StringRef(BufRef.data() + 3, BufRef.size() - 3);
+#ifdef LLVM_ON_WIN32
+  // Otherwise, this might be a hand-written text file encoded in the system's
+  // default code page.
+  else {
+    const UTF8 *Begin = reinterpret_cast<const UTF8 *>(BufRef.begin()),
+    if (!isLegalUTF8String(&Begin,
+           reinterpret_cast<const UTF8 *>(BufRef.end()))) {
+      if (!convertANSIToUTF8String(BufRef, UTF8Buf))
+        return false;
+      Str = StringRef(UTF8Buf);
+    }
+  }
+#endif
 
   // Tokenize the contents into NewArgv.
   Tokenizer(Str, Saver, NewArgv, MarkEOLs);