This is an archive of the discontinued LLVM Phabricator instance.

Include Stmt.h where it seems to be necessary for modules builds
ClosedPublic

Authored by rnk on Dec 9 2019, 1:05 PM.

Details

Summary

After 60573ae6fe50 removed an include of Expr.h from ASTContext.h, this
header fails to compile in some modular build configurations. I have not
been able to reproduce the problem locally. The header compiles fine in
isolation. However, based on reading the code, it seems like it would
require Stmt to be complete. Based on that intuition, we decided to add the
include.

Diff Detail

Event Timeline

rnk created this revision.Dec 9 2019, 1:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2019, 1:05 PM
rdhindsa accepted this revision.Dec 9 2019, 1:07 PM

LGTM

This revision is now accepted and ready to land.Dec 9 2019, 1:07 PM
This revision was automatically updated to reflect the committed changes.