This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers
ClosedPublic

Authored by mstorsjo on Dec 6 2019, 3:32 AM.

Details

Summary

If not set, the address byte size was implied to be the one of the host process.

This allows reverting the functional change from 31087b2ae9154, since now PECOFF does the same as ELF and MachO wrt setting both byte order and address size on m_data within ParseHeader.

Diff Detail

Event Timeline

mstorsjo created this revision.Dec 6 2019, 3:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2019, 3:32 AM

@labath does this one seem sensible and like what you suggested in D70848?

labath accepted this revision.Dec 10 2019, 1:21 AM

Sorry, I missed this one. Yes, I think this is fine.

This revision is now accepted and ready to land.Dec 10 2019, 1:21 AM
This revision was automatically updated to reflect the committed changes.