[LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers

[mstorsjo]

Summary

If not set, the address byte size was implied to be the one of the host process.

This allows reverting the functional change from 31087b2ae9154, since now PECOFF does the same as ELF and MachO wrt setting both byte order and address size on m_data within ParseHeader.

[mstorsjo]

@labath does this one seem sensible and like what you suggested in D70848?

[labath]

Sorry, I missed this one. Yes, I think this is fine.

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

if (ParseDOSHeader(m_data, m_dos_header)) {
       uint32_t pe_signature = m_data.GetU32(&offset);
       if (pe_signature != IMAGE_NT_SIGNATURE)
         return false;
       if (ParseCOFFHeader(m_data, &offset, m_coff_header)) {
         if (m_coff_header.hdrsize > 0)
           ParseCOFFOptionalHeader(&offset);
         ParseSectionHeaders(offset);
       }
+      m_data.SetAddressByteSize(GetAddressByteSize());
       return true;
     }
   }
   return false;
 }
 
 bool ObjectFilePECOFF::SetLoadAddress(Target &target, addr_t value,
                                       bool value_is_offset) {

lldb/source/Symbol/ObjectFile.cpp

DataBufferSP ObjectFile::ReadMemory(const ProcessSP &process_sp,
   }
   return data_sp;
 }
 
 size_t ObjectFile::GetData(lldb::offset_t offset, size_t length,
                            DataExtractor &data) const {
   // The entire file has already been mmap'ed into m_data, so just copy from
   // there as the back mmap buffer will be shared with shared pointers.
-  size_t ret = data.SetData(m_data, offset, length);
-  // DataExtractor::SetData copies the address byte size from m_data, but
-  // m_data's address byte size is only set from sizeof(void*), and we can't
-  // access subclasses GetAddressByteSize() when setting up m_data in the
-  // constructor.
-  data.SetAddressByteSize(GetAddressByteSize());
-  return ret;
+  return data.SetData(m_data, offset, length);
 }
 
 size_t ObjectFile::CopyData(lldb::offset_t offset, size_t length,
                             void *dst) const {
   // The entire file has already been mmap'ed into m_data, so just copy from
   // there Note that the data remains in target byte order.
   return m_data.CopyData(offset, length, dst);
 }