Set a source location for Objective-C accessor stubs

[aprantl]

Summary

Set a source location for Objective-C accessor stubs even when there is no explicit synthesize statement.

This fixes a regression introduced in https://reviews.llvm.org/D68108 that could lead to missing debug locations in cleanup code in synthesized Objective-C++ properties.

[vsk]

Shall we add in the assert we discussed in CFG::FinishFunction, as an additional test?

[aprantl]

In D71084#1771501, @vsk wrote:

Shall we add in the assert we discussed in CFG::FinishFunction, as an additional test?

Done over in https://reviews.llvm.org/D71042

[vsk]

LGTM.

clang/lib/Sema/SemaObjCProperty.cpp

 
 /// Create a synthesized property accessor stub inside the \@implementation.
 static ObjCMethodDecl *
 RedeclarePropertyAccessor(ASTContext &Context, ObjCImplementationDecl *Impl,
                           ObjCMethodDecl *AccessorDecl, SourceLocation AtLoc,
                           SourceLocation PropertyLoc) {
   ObjCMethodDecl *Decl = AccessorDecl;
   ObjCMethodDecl *ImplDecl = ObjCMethodDecl::Create(
-      Context, AtLoc, PropertyLoc, Decl->getSelector(), Decl->getReturnType(),
+      Context, AtLoc.isValid() ? AtLoc : Decl->getBeginLoc(),
+      PropertyLoc.isValid() ? PropertyLoc : Decl->getEndLoc(),
+      Decl->getSelector(), Decl->getReturnType(),
       Decl->getReturnTypeSourceInfo(), Impl, Decl->isInstanceMethod(),
-      Decl->isVariadic(), Decl->isPropertyAccessor(), /* isSynthesized*/ true,
-      Decl->isImplicit(), Decl->isDefined(), Decl->getImplementationControl(),
-      Decl->hasRelatedResultType());
+      Decl->isVariadic(), Decl->isPropertyAccessor(),
+      /* isSynthesized*/ true, Decl->isImplicit(), Decl->isDefined(),
+      Decl->getImplementationControl(), Decl->hasRelatedResultType());
   ImplDecl->getMethodFamily();
   if (Decl->hasAttrs())
     ImplDecl->setAttrs(Decl->getAttrs());
   ImplDecl->setSelfDecl(Decl->getSelfDecl());
   ImplDecl->setCmdDecl(Decl->getCmdDecl());
   SmallVector<SourceLocation, 1> SelLocs;
   Decl->getSelectorLocs(SelLocs);
   ImplDecl->setMethodParams(Context, Decl->parameters(), SelLocs);

clang/test/SemaObjC/default-synthesize-sourceloc.m

+// RUN: %clang_cc1 -ast-dump %s | FileCheck %s
+
+// Test that accessor stubs for default-synthesized ObjC accessors
+// have a valid source location.
+
+__attribute__((objc_root_class))
+@interface NSObject
++ (id)alloc;
+@end
+
+@interface NSString : NSObject
+@end
+
+@interface MyData : NSObject
+struct Data {
+    NSString *name;
+};
+@property struct Data data;
+@end
+// CHECK: ObjCImplementationDecl {{.*}}line:[[@LINE+2]]{{.*}} MyData
+// CHECK: ObjCMethodDecl {{.*}}col:23 implicit - setData: 'void'
+@implementation MyData
+@end