This is an archive of the discontinued LLVM Phabricator instance.

Differential D7085

Replace size call with empty call where appripriate in clang/tools/extra
ClosedPublic

Authored by xazax.hun on Jan 21 2015, 3:27 AM.

Details

Reviewers
alexfh
Summary

Replace size call with empty call where appropriate in clang/tools/extra. This patch is the result of applying fixes of the ContainerSizeEmpty Clang-Tidy checker which was committed recently.

Diff Detail

Event Timeline

xazax.hun updated this revision to Diff 18492.Jan 21 2015, 3:27 AM
xazax.hun retitled this revision from to Replace size call with empty call where appripriate in clang/tools/extra.
xazax.hun updated this object.
xazax.hun edited the test plan for this revision. (Show Details)
xazax.hun added a reviewer: alexfh.
xazax.hun added a subscriber: Unknown Object (MLST).
alexfh accepted this revision.Jan 22 2015, 5:14 AM
alexfh edited edge metadata.

Looks good. I'll commit the patch for you.

This revision is now accepted and ready to land.Jan 22 2015, 5:14 AM
alexfh closed this revision.Jan 22 2015, 5:16 AM

Committed revision 226817.

Revision Contents

PathSize
modularize/
2 lines
module-map-checker/
2 lines

Diff 18492

modularize/ModuleAssistant.cpp

Context not available.
// Destructor. // Destructor.
Module::~Module() { Module::~Module() {
// Free submodules. // Free submodules.
while (SubModules.size()) { while (!SubModules.empty()) {
Module *last = SubModules.back(); Module *last = SubModules.back();
SubModules.pop_back(); SubModules.pop_back();
delete last; delete last;
Context not available.

module-map-checker/ModuleMapChecker.cpp

Context not available.
findUnaccountedForHeaders(); findUnaccountedForHeaders();
// Check for warnings. // Check for warnings.
if (UnaccountedForHeaders.size()) if (!UnaccountedForHeaders.empty())
returnValue = std::error_code(1, std::generic_category()); returnValue = std::error_code(1, std::generic_category());
// Dump module map if requested. // Dump module map if requested.
Context not available.