Page MenuHomePhabricator

[LegalizeTypes] Add SoftenFloatRes_Unary and SoftenFloatRes_Binary functions to factor repeated patterns out of many of the SoftenFloatRes_* functions
ClosedPublic

Authored by craig.topper on Tue, Nov 26, 11:47 AM.

Details

Summary

This has been factored out of D70654 which will add strict FP support to these functions. By making the helpers we avoid repeating even more code.

Diff Detail

Event Timeline

craig.topper created this revision.Tue, Nov 26, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Nov 26, 11:47 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
craig.topper marked an inline comment as done.Tue, Nov 26, 11:47 AM
craig.topper added inline comments.
llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
200–205

Are these functions simple enough now that we should just inline this into the switch?

efriedma accepted this revision.Tue, Nov 26, 12:33 PM

LGTM

llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
200–205

Inlining wouldn't make it easier to read, I think.

We could turn the opcode->rtlib call mapping into a table, then merge all the switch cases, if you wanted to. But I don't think that's necessary.

This revision is now accepted and ready to land.Tue, Nov 26, 12:33 PM
This revision was automatically updated to reflect the committed changes.