This has been factored out of D70654 which will add strict FP support to these functions. By making the helpers we avoid repeating even more code.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp | ||
---|---|---|
200–205 | Are these functions simple enough now that we should just inline this into the switch? |
Comment Actions
LGTM
llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp | ||
---|---|---|
200–205 | Inlining wouldn't make it easier to read, I think. We could turn the opcode->rtlib call mapping into a table, then merge all the switch cases, if you wanted to. But I don't think that's necessary. |
Are these functions simple enough now that we should just inline this into the switch?