Page MenuHomePhabricator

[macho] Allow CPUSubtype to be adjusted before writing it to a file
ClosedPublic

Authored by dsanders on Nov 15 2019, 2:59 PM.

Details

Summary

It's not always possible for a target to provide a MachO CPUSubtype up
front as is required by the current implementation. Sometimes you need more
information like the particular CPU implementation you are targeting.

Give MCMachObjectTargetWriter subclasses the opportunity to modify the
CPUSubtype after the MCMachObjectTargetWriter is created but before the
object starts being written. Typically this would be done in response to
instructions from a TargetStreamer.

Diff Detail

Event Timeline

dsanders created this revision.Nov 15 2019, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2019, 2:59 PM
pete accepted this revision.Nov 15 2019, 3:37 PM

LGTM

This revision is now accepted and ready to land.Nov 15 2019, 3:37 PM
This revision was automatically updated to reflect the committed changes.