This is an archive of the discontinued LLVM Phabricator instance.

[zorg] Fix get slave environment in LLDB Windows builder.
AbandonedPublic

Authored by rfoos on Jan 16 2015, 11:19 AM.

Details

Summary

Fixes original get visual studio environment from running on master to run on buildslave.

get LLDB source is now a function.

Default clean step set to false.

Adds install step, and test (ignore errors) step.

Diff Detail

Repository
rL LLVM

Event Timeline

rfoos updated this revision to Diff 18307.Jan 16 2015, 11:19 AM
rfoos retitled this revision from to [zorg] Fix get slave environment in LLDB Windows builder..
rfoos updated this object.
rfoos edited the test plan for this revision. (Show Details)
rfoos added reviewers: gkistanova, zturner.
rfoos set the repository for this revision to rL LLVM.
rfoos added a project: Restricted Project.
rfoos added subscribers: Unknown Object (MLST), ted.
rfoos added inline comments.Jan 16 2015, 11:21 AM
zorg/buildbot/builders/LLDBBuilder.py
12

Duplicate line removed.

rfoos added inline comments.Jan 19 2015, 11:07 AM
zorg/buildbot/builders/LLDBBuilder.py
136

Add flunkOnFailure=False until test suite is working. This allows success on compiles.

I think this is ready to go. I'm getting 6 minute builds and pass/fail on lldb builds.

rfoos planned changes to this revision.Jan 20 2015, 3:03 PM

Planned Changes completed.

rfoos updated this revision to Diff 18462.Jan 20 2015, 3:08 PM
rfoos removed a subscriber: ted.

Duplicate imports removed.
check-lldb step added to debug test suite. flunkOnFailure True to ignore errors.
Install step added to test final executable packaging with Python.

Drop in replacement for existing builders.

gkistanova edited edge metadata.Jan 20 2015, 5:05 PM

Hi Rick,

Please see my comment in-line.

Also, could you re-generate the patch, please?
The attached one seems broken.

Thanks
Glaina.

zorg/buildbot/builders/LLDBBuilder.py
87

You have imported RemoveDirectory. Did you plan using it here instead of the direct use of the Windows-specific command?

rfoos added a comment.Jan 20 2015, 5:49 PM

http://reviews.llvm.org/D7077

Sorry about RemoveDirectory. It was part of some internal modifications.

I change clean to the RemoveDirectory step I'm going to add in the
generic cmake builder (working, coming very soon).

Thanks
Rick

Hi Zachary,

The nifty VS120COMNTOOLS environment variable doesn't work on your Windows 8.

I have no idea why, but maybe you need a filepath like you were using before.

So much for a default that runs on any windows machine :(

The slave_envCmd argument will let you pass something different.

Rick

'\"C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\Tools\/../../VC/vcvarsall.bat\"' is not recognized as an internal or external command,
operable program or batch file.
program finished with exit code 1
elapsedTime=0.109000

zturner edited edge metadata.Jan 23 2015, 7:43 AM

Strange. It's resolving the environment var, just not finding anything
there. I wonder if its an issue wit / and \. Can you try os.path.normpath()
first?

rfoos added a comment.Jan 23 2015, 8:06 AM

Something like that.

The os.path.join's run on the linux master, so they are forward slash. I
changed that part for double backslash.

It looks like the \"'s are not being escaped, which is still a puzzle.

I've got a patch that changes everything that wasn't working right.

A few rounds and we'll have this resolved.

Rick